Allow for issues/PRs to be closed after manually being marked as stale #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this action would stop and skip all issues or pull requests it found if no `stale-issue-message | stale-pr-message` option had been configured. In practise that meant this action could not be used in repositories where the maintainers would want to manually mark issues and pull requests as stale, instead of this action being responsible for the said marking. That's what these changes allows for, maintainers being responsible for marking, but still want help from this action to close those issues or pull requests X days after they got manually marked as stale by labelling them. Configuring `days-before-stale: -1` will activate that behaviour.
|
Forgot to cross link this with nodejs/github-bot#261 where we've discussed using this action to close issues and pull requests in nodejs/node. |
hross
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this action would stop and skip all issues or pull requests it found if no
stale-issue-message | stale-pr-messageoption had been configured.In practise that meant this action could not be used in repositories where the maintainers would want to manually mark issues and pull requests as stale, instead of this action being responsible for the said marking.
That's what these changes allows for, maintainers being responsible for marking, but still want help from this action to close those issues or pull requests X days after they got manually marked as stale by labelling them.
Configuring
days-before-stale: -1will activate that behaviour, inspired by howdays-before-close: -1works already.Would that sound like a good fit for this action by any chance?