Autoclosing issues/PRs labeled "stalled" after 30 days #261
Comments
|
Cool idea. I would assume it's possible for us to resolve PRs by that label once a day or similar. Has there been any discussion in core to use GitHub Actions for things like this? I stumbled upon the stale actions recently. Taking some inspiration from that to close PRs with a specific label might not be too far fetched 🤷♂️ |
|
We use an action for that on nodejs/build: https://github.com/nodejs/build/blob/master/.github/workflows/stale.yml. I don't think implementing this in the bot is worth the effort + maintenance cost. |
|
That stale action' only-labels:
description: 'Only issues or pull requests with all of these labels are checked if stale. Defaults to `[]` (disabled) and can be a comma-separated list of labels.' |
|
@jasnell would it be valuable if I confirmed the stale GitHub Action indeed solves what you're asking? Or are we shying away from Actions use in core for some reason? |
|
@phillipj ... That would be great. The one caveat is that we really ought to avoid automatic stale marking. |
|
Noted. I'll setup a test repo to see how it behaves and report back. Thx for the quick reply! |
|
@phillipj you can also use nodejs/node-auto-test if you want |
|
TLDR; it works. Had to fork the stale Action and make minor modifications, primarily because we want to perform the I agree with @mmarchini on his point using an Action for this vs our beloved github-bot. Feels a lot simpler to grasp due to the reduced code base, more focused, and likely easier for core collaborators to tweak or throw away when not wanted anymore. Other than doing a few example runs in nodejs/node-auto-test, does the idea of using an action for this sound reasonable? Refs: stale Action modifications, Action config, closed issue and not closed issue. |
|
imo if you can show an issue getting closed and one not getting closed/labeled in any repository (and you already did that) that's good enough to send a PR to nodejs/node. Also, I don't see a problem with forked Actions, they were built so they could be forked. |
|
Cool! I'll see if I can find different set of changes that could land into the upstream stale Action project, as opposed to forking in and deleting a few lines we don't want to run. Will open a PR against nodejs/node afterwards. |
|
Worst case we could use a really big number (like 9999999, which is more than two thousand years) of days to mark an issue as stale 🤷 |
|
Latest update on this; changes has landed in the upstream stale action project. That means we can use that GitHub Action out of the box. Awaiting them to build & push a new version, before opening a PR to nodejs/node. |
This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs nodejs/github-bot#261 PR-URL: #34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs nodejs/github-bot#261 PR-URL: #34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
|
Closing this as it feels like we've settled for realising this with a GitHub Action in nodejs/node instead of our beloved @nodejs-github-bot. |
This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs nodejs/github-bot#261 PR-URL: #34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs nodejs/github-bot#261 PR-URL: #34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs nodejs/github-bot#261 PR-URL: nodejs#34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Would it be possible for the bot to automatically close issues/prs 30 days after they have manually been labeled "stalled", along with a comment added as to why it is being closed. I don't want to get into auto-labeling stalled issues just yet but automatically cleaning up those that have been labeled would be good.
The text was updated successfully, but these errors were encountered: