Skip to content

How to deal with comments #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timoschilling opened this issue Jan 17, 2015 · 6 comments
Closed

How to deal with comments #23

timoschilling opened this issue Jan 17, 2015 · 6 comments

Comments

@timoschilling
Copy link
Member

I think the timeouts come from to much comments in the database.

Since now we have a Heroku scheduler wich deletes the comments each hour.

I have following the logs during the first scheduler run, before it starts we have 99% timeouts, ~1 minute after the run the timeouts going down to 0%.

There are 3 way to go for the future:

  1. turing off comments (Switch over to Rails4 #22)
  2. IP blocking (Implement a permanent IP ban #14)
  3. login required comments (Github Auth as Login #21)
  4. Comment Captcha
  5. cleanup
  6. delete all comments each hour (current behavior)
  7. delete comments older then x hours each hour

My opinions are:

  1. it reduce the fictionality 👎
  2. it never catch all IP's and sometimes to many 👎
  3. will stop users from trying the demo 👎
  4. it's ok, but nobody likes Captchas 👎
  5. can result in adding a comment and don't seeing it 👎
  6. removing old comments should not disturb anybody 👍

I'm interested in, what others think about this? // cc: @seanlinsley, @pcreux, @eshaiju

@pcreux
Copy link
Contributor

pcreux commented Jan 17, 2015

I like the idea of logging in using Github. I am wondering if using Cloudflare or so wouldn't help with preventing bots. Clouflare seems to prevent "attacks"...

@seanlinsley
Copy link
Contributor

I think it's fine to require Github OAuth login (#21) since 99% of people looking to use ActiveAdmin are going to have a Github account. We just need to make sure not to:

  • request anything but the most basic of permissions
  • store the OAuth private key in the repo (it should be stored in heroku config)

@timoschilling
Copy link
Member Author

@seanlinsley you mean "not in the repo" right? If yes, I agree with you

@pcreux
Copy link
Contributor

pcreux commented Jan 17, 2015

Yes, it was a list of things not to do with double negations. :)

On Sat Jan 17 2015 at 3:36:21 AM Timo Schilling notifications@github.com
wrote:

@seanlinsley https://github.com/seanlinsley you mean "not in the repo"
right? If yes, I agree with you


Reply to this email directly or view it on GitHub
#23 (comment)
.

@timoschilling
Copy link
Member Author

Sorry, I didn't read the not in "We just need to make sure not to:"

@timoschilling
Copy link
Member Author

I'm closing this, there is still the #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants