Skip to content

Switch over to Rails4 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 17, 2015
Merged

Switch over to Rails4 #22

merged 20 commits into from
Jan 17, 2015

Conversation

pcreux
Copy link
Contributor

@pcreux pcreux commented Dec 29, 2014

@eshaiju did a great job migrating this demo over to rails4. I've fixed a few things here and there.

This demo is currently running at http://demo-aa-rails4.herokuapp.com/admin

Notes:

  • hoptoad is not being used anymore
  • comments are disabled. This might prevent bots from messing around with the app.
  • Integration tests for the store have been removed

@seanlinsley
Copy link
Contributor

Thanks for working on this!

It doesn't look like comments are currently disabled. I just left one on http://demo-aa-rails4.herokuapp.com/admin/customers/58

screen shot 2014-12-28 at 9 43 07 pm

@orendon
Copy link

orendon commented Dec 29, 2014

👍 for this update

btw, comments are still enabled here and here

@pcreux
Copy link
Contributor Author

pcreux commented Dec 29, 2014

@seanlinsley Thanks for leaving a comment! :)

Ok, I disabled them everywhere. Thanks for the pointers @orendon.

@timoschilling
Copy link
Member

@pcreux do you want to replace http://demo.activeadmin.info with this? What do you think about, a landingpage on demo.activeadmin.info with links to v0-6.demo.activeadmin.info and v1-0.demo.activeadmin.info?

@pcreux
Copy link
Contributor Author

pcreux commented Dec 30, 2014

@timoschilling The demo allows prospects who visited the landing page (http://activeadmin.info) to play with ActiveAdmin. They don't know about v0.6 / v1 at that point. I don't think that it brings much value to add this choice.

I'm also concerned with maintaining 2 demo apps (looks like we can't get 1 to handle the load), I believe that 0.6 and 1.0 are quite close and that most people will play with 1.0 anyway.

@eshaiju
Copy link
Contributor

eshaiju commented Jan 11, 2015

HI @timoschilling

What happen to this PR?

@timoschilling
Copy link
Member

I think we should merge this.

@pcreux can you add me to the heruko app? Then can we use your app as base for demo.activeadmin.info, I will change the DNS, if you agree.

@pcreux
Copy link
Contributor Author

pcreux commented Jan 16, 2015

@timo, I could just migrate the existing app to cedar14 and push this code
to it.

On a separate note, would using Cloudflare help us staying up and running?
On Fri Jan 16 2015 at 3:07:15 PM Timo Schilling notifications@github.com
wrote:

I think we should merge this.

@pcreux https://github.com/pcreux can you add me to the heruko app?
Then can we use your app as base for demo.activeadmin.info, I will change
the DNS, if you agree.


Reply to this email directly or view it on GitHub
#22 (comment)
.

@timoschilling
Copy link
Member

@pcreux do it

pcreux added a commit that referenced this pull request Jan 17, 2015
@pcreux pcreux merged commit 429da37 into activeadmin:master Jan 17, 2015
@pcreux pcreux deleted the rails4 branch January 17, 2015 01:16
@pcreux
Copy link
Contributor Author

pcreux commented Jan 17, 2015

Done & deployed

@timoschilling
Copy link
Member

@pcreux 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants