Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Space point implementation #1900

Closed

Conversation

CarloVarni
Copy link
Collaborator

@CarloVarni CarloVarni commented Feb 27, 2023

Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding.

This also removed the following classes: InternalSpacePoint and InternalSeed

@CarloVarni CarloVarni added 🚧 WIP Work-in-progress Component - Core Affects the Core module labels Feb 27, 2023
@tboldagh
Copy link
Contributor

tboldagh commented Mar 1, 2023

Hi Carlo, I think this is what we want. From what I looked at the code there may be few missing pieces (to be able to build this container). And I have some technical questions/doubts.

@CarloVarni CarloVarni added the 🛑 blocked This item is blocked by another item label Mar 20, 2023
@CarloVarni
Copy link
Collaborator Author

this now needs both #1948 and #1966

@CarloVarni CarloVarni added this to the next milestone Apr 4, 2023
@stale
Copy link

stale bot commented May 20, 2023

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label May 20, 2023
@CarloVarni
Copy link
Collaborator Author

still a lot of work to do here, but the basic structure is in place. @paulgessinger @tboldagh can you take a look at this?

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Attention: Patch coverage is 11.50895% with 346 lines in your changes missing coverage. Please review.

Project coverage is 48.71%. Comparing base (d8e46ff) to head (bad00ac).
Report is 374 commits behind head on main.

Files Patch % Lines
Core/include/Acts/EventData/SpacePointData.ipp 0.00% 92 Missing ⚠️
...ore/include/Acts/EventData/SpacePointContainer.ipp 0.00% 61 Missing ⚠️
Core/include/Acts/Seeding/SpacePointGrid.ipp 0.00% 42 Missing ⚠️
Core/include/Acts/Seeding/SeedFinder.ipp 0.00% 31 Missing ⚠️
Core/include/Acts/EventData/SpacePointProxy.ipp 0.00% 30 Missing ⚠️
Core/include/Acts/Seeding/SeedFilter.ipp 0.00% 20 Missing ⚠️
...ore/include/Acts/EventData/SpacePointContainer.hpp 0.00% 17 Missing ⚠️
...e/include/Acts/EventData/SpacePointMutableData.ipp 0.00% 13 Missing ⚠️
...include/Acts/EventData/SpacePointProxyIterator.ipp 0.00% 12 Missing ⚠️
Core/include/Acts/Seeding/BinnedGroupIterator.ipp 69.69% 2 Missing and 8 partials ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   48.90%   48.71%   -0.19%     
==========================================
  Files         491      498       +7     
  Lines       28561    28691     +130     
  Branches    13487    13569      +82     
==========================================
+ Hits        13967    13978      +11     
- Misses       4861     4980     +119     
  Partials     9733     9733              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Jul 14, 2024
@CarloVarni CarloVarni changed the title feat!: Space point implementation feature!: Space point implementation Jul 23, 2024
@CarloVarni CarloVarni changed the title feature!: Space point implementation feat!: Space point implementation Jul 23, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.5% Coverage on New Code (required ≥ 25%)
11 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
0.83% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@CarloVarni CarloVarni closed this Jul 24, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
kodiakhq bot pushed a commit that referenced this pull request Sep 27, 2024
… in the seeding (#3432)

Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding. Taken from  #1900 but squashed

This also removed the following classes: `InternalSpacePoint` and `InternalSeed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change This change breaks backwards compatibility Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module 👷‍♀️ User Action Needed Event Data Model Needs Decision Needs decision or further information Needs Discussion Seeding Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants