feat!: Track-EDM like implementation for the space points, to be used in the seeding #3432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
|
Closed
andiwand
reviewed
Sep 25, 2024
Examples/Framework/include/ActsExamples/EventData/SpacePointContainer.hpp
Outdated
Show resolved
Hide resolved
Examples/Framework/include/ActsExamples/EventData/SpacePointContainer.hpp
Show resolved
Hide resolved
|
Super happy to see this development! |
added 2 commits
September 25, 2024 19:46
andiwand
approved these changes
Sep 27, 2024
|
acts-project-service
added
Breaks Athena build
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Future support for seeds created from `N` space points, with `N >= 3`. The seed EDM naturally support the possibility of requiring more than 3 space points, so the Seed class is now templated on both the external space point type and the required number of space points: `Seed<external_spacepoint_t, N>`. By default `N == 3`, and there is a requirement that `N >= 3`. The default values is to avoid a breaking change in the code. This PR requires #3432
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
… in the seeding (acts-project#3432) Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding. Taken from acts-project#1900 but squashed This also removed the following classes: `InternalSpacePoint` and `InternalSeed`
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
Future support for seeds created from `N` space points, with `N >= 3`. The seed EDM naturally support the possibility of requiring more than 3 space points, so the Seed class is now templated on both the external space point type and the required number of space points: `Seed<external_spacepoint_t, N>`. By default `N == 3`, and there is a requirement that `N >= 3`. The default values is to avoid a breaking change in the code. This PR requires acts-project#3432
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
… in the seeding (acts-project#3432) Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding. Taken from acts-project#1900 but squashed This also removed the following classes: `InternalSpacePoint` and `InternalSeed`
njacazio
pushed a commit
to njacazio/acts
that referenced
this pull request
Jun 13, 2025
Future support for seeds created from `N` space points, with `N >= 3`. The seed EDM naturally support the possibility of requiring more than 3 space points, so the Seed class is now templated on both the external space point type and the required number of space points: `Seed<external_spacepoint_t, N>`. By default `N == 3`, and there is a requirement that `N >= 3`. The default values is to avoid a breaking change in the code. This PR requires acts-project#3432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read-only implementation of the space point EDM, following the examples from Tracks and MTJ. The seeding infrastructures have been adapted to this, both the default and orthogonal seeding. Taken from #1900 but squashed
This also removed the following classes:
InternalSpacePointandInternalSeed