Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix some Geant4<->Acts unit conversions #2264

Merged
merged 6 commits into from
Jul 5, 2023
Merged

fix: Fix some Geant4<->Acts unit conversions #2264

merged 6 commits into from
Jul 5, 2023

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Jul 4, 2023 •
edited
Loading

Adds missing mass and time conversion factors

blocked by

@andiwand andiwand added the Component - Plugins Affects one or more Plugins label Jul 4, 2023
@andiwand andiwand added this to the next milestone Jul 4, 2023
@andiwand andiwand mentioned this pull request Jul 4, 2023
Merged
@github-actions github-actions bot added Component - Examples Affects the Examples module and removed Component - Plugins Affects one or more Plugins labels Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #2264 (d7d58bf) into main (c0b9fcc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2264   +/-   ##
=======================================
  Coverage   49.27%   49.27%           
=======================================
  Files         450      450           
  Lines       25410    25410           
  Branches    11724    11724           
=======================================
  Hits        12521    12521           
  Misses       4556     4556           
  Partials     8333     8333

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 4, 2023 •
edited
Loading

📊 Physics performance monitoring for d7d58bf

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Corentin-Allaire
Corentin-Allaire approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for the PR

@andiwand andiwand added 🛑 blocked This item is blocked by another item and removed automerge 🛑 blocked This item is blocked by another item labels Jul 5, 2023
@kodiakhq kodiakhq bot merged commit 0ad1e47 into acts-project:main Jul 5, 2023
@github-actions github-actions bot removed the automerge label Jul 5, 2023
@andiwand andiwand deleted the fix-geant4-unit-conversions branch July 5, 2023 19:21
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 5, 2023 •
edited
Loading

✅ Athena integration test results

✅ All tests successful

status job
🟢 run_unit_tests
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsTrkSpacePoints.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 5, 2023
@paulgessinger
Copy link
Member

Failure was unrelated.

@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Jul 6, 2023
kodiakhq bot pushed a commit that referenced this pull request Jul 6, 2023
@andiwand
ci: Physmon for event simulation (#2232)
b513232 
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4.

The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation.

Possible improvements:
- record deltas for momenta / eta / phi and so on instead of initial and final

Blocked by
- #2241
- #2260
- #2262
- #2263
- #2264
- #2265
- #2266
@paulgessinger paulgessinger removed this from the next milestone Jul 24, 2023
@paulgessinger paulgessinger added this to the v27.2.0 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corentin-Allaire Corentin-Allaire Corentin-Allaire approved these changes

Assignees
No one assigned
Labels
Changes Performance Component - Examples Affects the Examples module
Projects
None yet
Milestone
v27.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @acts-project-service @paulgessinger @Corentin-Allaire