refactor: Drop bool conversion in favor of isAlive method in Fatras::Particle
#2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2266 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 449 449
Lines 25408 25408
Branches 11724 11724
=======================================
Hits 12521 12521
Misses 4554 4554
Partials 8333 8333 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for dd4a92fSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
Allows to filter secondary particles with `ParticleSelector` blocked by - #2266
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
All our physics monitors depend on the simulation which is not directly monitored at the moment. In this PR I add a first monitoring version for Fatras and Geant4. The monitoring is not optimal yet but should be sufficient if something changes or breaks for simulation. Possible improvements: - record deltas for momenta / eta / phi and so on instead of initial and final Blocked by - #2241 - #2260 - #2262 - #2263 - #2264 - #2265 - #2266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the state check for the particle more explicit