Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename vc to vc_aos and build vc_soa plugin in CI #839

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Sep 27, 2024

Rename the Vc plugin to Vc_AoS to distinguish it from the Vc_SoA plugin and build the latter in the CI. Also makes sure that the cmake developer preset pre-fetches all of the algebra plugins.

This also silences the compiler warnings stemming from the Vc build (see acts-project/traccc#711).

@niermann999 niermann999 added refactor refactoring the current codes priority: low Low priority labels Sep 27, 2024
@niermann999 niermann999 force-pushed the feat-switch-on-vcsoa branch 4 times, most recently from ff422b0 to f726644 Compare September 27, 2024 15:18
@niermann999 niermann999 force-pushed the feat-switch-on-vcsoa branch 2 times, most recently from 9a946fa to 3071535 Compare October 2, 2024 13:10
@niermann999 niermann999 force-pushed the feat-switch-on-vcsoa branch from 3071535 to cafec8a Compare October 4, 2024 15:31
Copy link

sonarqubecloud bot commented Oct 4, 2024

Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niermann999 niermann999 merged commit 48801b8 into acts-project:main Oct 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants