Silence Vc Warning(s), main branch (2024.09.21.) #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
force-pushed
the
SilenceVcWarning-main-20240921
branch
from
6a9ef16 to
de1ec13
Compare
The Vc source code generates warnings with GCC and Clang when using C++20. This takes care of silencing those warnings.
krasznaa
force-pushed
the
SilenceVcWarning-main-20240921
branch
from
de1ec13 to
1b3b0e5
Compare
niermann999
added a commit
to acts-project/detray
that referenced
this pull request
Oct 7, 2024
…in and build the latter in the CI (#839) Rename the Vc plugin to Vc_AoS to distinguish it from the Vc_SoA plugin and build the latter in the CI. Also makes sure that the cmake developer preset pre-fetches all of the algebra plugins. This also silences the compiler warnings stemming from the Vc build (see acts-project/traccc#711).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vc source code generates warnings with GCC and Clang when using C++20. Warnings like:
This takes care of silencing those warnings.
Note that the warnings are not coming from compiling this project's code, but rather from compiling the source files of Vc itself. In the same manner, the flag is only added to that build. The rest of the project doesn't receive this flag.