Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence Vc Warning(s), main branch (2024.09.21.) #711

Merged

Conversation

krasznaa
Copy link
Member

The Vc source code generates warnings with GCC and Clang when using C++20. Warnings like:

[143/492] Building CXX object _deps/vc-build/CMakeFiles/Vc.dir/trigonometric_AVX2+FMA+BMI2.cpp.o
In file included from /data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-build/trigonometric_AVX2+FMA+BMI2.cpp:31:
In file included from /data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-src/Vc/vector.h:32:
In file included from /data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-src/Vc/scalar/vector.h:39:
In file included from /data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-src/Vc/scalar/types.h:28:
In file included from /data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-src/Vc/scalar/../common/types.h:37:
/data/ssd-1tb/projects/traccc/build-sycl/_deps/vc-src/Vc/scalar/../common/../global.h:609:5: warning: arithmetic between different enumeration types ('Vc_1::Implementation' and 'Vc_1::ExtraInstructions') is deprecated [-Wdeprecated-enum-enum-conversion]
  585 |     + Vc::PopcntInstructions
      |     ^ ~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

This takes care of silencing those warnings.

Note that the warnings are not coming from compiling this project's code, but rather from compiling the source files of Vc itself. In the same manner, the flag is only added to that build. The rest of the project doesn't receive this flag.

@krasznaa krasznaa added the build This relates to the build system label Sep 21, 2024
@krasznaa krasznaa force-pushed the SilenceVcWarning-main-20240921 branch from 6a9ef16 to de1ec13 Compare September 21, 2024 15:36
The Vc source code generates warnings with GCC and Clang
when using C++20. This takes care of silencing those
warnings.
@krasznaa krasznaa force-pushed the SilenceVcWarning-main-20240921 branch from de1ec13 to 1b3b0e5 Compare September 21, 2024 16:14
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephenswat stephenswat merged commit 5127dcd into acts-project:main Sep 23, 2024
21 of 24 checks passed
@krasznaa krasznaa deleted the SilenceVcWarning-main-20240921 branch September 23, 2024 11:29
niermann999 added a commit to acts-project/detray that referenced this pull request Oct 7, 2024
…in and build the latter in the CI (#839)

Rename the Vc plugin to Vc_AoS to distinguish it from the Vc_SoA plugin and build the latter in the CI. Also makes sure that the cmake developer preset pre-fetches all of the algebra plugins.

This also silences the compiler warnings stemming from the Vc build (see acts-project/traccc#711).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build This relates to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants