Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract shift as constexpr instead of consteval #926

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: extract shift as constexpr instead of consteval #926

merged 1 commit into from
Feb 4, 2025

Conversation

niermann999
Copy link
Contributor

llvm does not seem to like the consteval keyword here (I think it is a compiler bug though)

@niermann999 niermann999 added refactor refactoring the current codes priority: high high priority labels Feb 4, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@niermann999 niermann999 mentioned this pull request Feb 4, 2025
Merged
asalzburger
asalzburger approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@niermann999 niermann999 merged commit 5883346 into acts-project:main Feb 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
priority: high high priority refactor refactoring the current codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niermann999 @asalzburger