-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing typename in sanity checks #839
Fix missing typename in sanity checks #839
Conversation
acts-project/acts#4068 exposes a mistake in our sanity checks, revealing that there are some missing typename keywords. This commit fixes those errors by adding the necessary keywords.
aa46462
to
64acf77
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious that none of the CI compilers complained about this. 😕 Do we possibly need some additional Debug builds? 🤔 Though we do have Debug builds with both GCC and Clang (oneAPI).
Should we add "vanilla" Clang Release+Debug builds as well to the CI? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I might need a new release then for this.
Can we build a patch release 19.0.1 with the fix? |
That could absolutely be done. We may as well build |
I am just guessing, but hopefully acts-project/detray#926 will do the trick |
acts-project/acts#4068 exposes a mistake in our sanity checks, revealing that there are some missing typename keywords. This commit fixes those errors by adding the necessary keywords.