Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing typename in sanity checks #839

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

stephenswat
Copy link
Member

acts-project/acts#4068 exposes a mistake in our sanity checks, revealing that there are some missing typename keywords. This commit fixes those errors by adding the necessary keywords.

@stephenswat stephenswat added the bug Something isn't working label Feb 4, 2025
acts-project/acts#4068 exposes a mistake in our
sanity checks, revealing that there are some missing typename keywords.
This commit fixes those errors by adding the necessary keywords.
Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious that none of the CI compilers complained about this. 😕 Do we possibly need some additional Debug builds? 🤔 Though we do have Debug builds with both GCC and Clang (oneAPI).

Should we add "vanilla" Clang Release+Debug builds as well to the CI? 🤔

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I might need a new release then for this.

@asalzburger
Copy link
Contributor

Can we build a patch release 19.0.1 with the fix?

@krasznaa
Copy link
Member

krasznaa commented Feb 4, 2025

Can we build a patch release 19.0.1 with the fix?

That could absolutely be done. We may as well build 20.0.0, since updates continue coming in. But as I saw it, Detray will also need some fixes. We should test that things work correctly with the main branch in Acts before making any new tags...

@niermann999
Copy link
Contributor

Can we build a patch release 19.0.1 with the fix?

That could absolutely be done. We may as well build 20.0.0, since updates continue coming in. But as I saw it, Detray will also need some fixes. We should test that things work correctly with the main branch in Acts before making any new tags...

I am just guessing, but hopefully acts-project/detray#926 will do the trick

@stephenswat stephenswat merged commit 9ab2654 into acts-project:main Feb 4, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants