You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the study of acts-project/traccc#869
Also this seems working better with traccc tests when I just use default propagation config.
In case of initializing the candidate search at the new volume or beginning of the propagation, the path tolerance is used instead of overstep tolerance. Currently, there is a bug that track goes backward if it finds surface in opposite direction when navigator::init is called at the very beginning of propagation
For example, in the telescope geometry whose envelope size is less than 1 mm, if I start the propagation at the first module, the track will just go back to the portal and terminate the propagation.
The reason will be displayed to describe this comment to others. Learn more.
I think that probably the envelopes on the telescope and toy detector should be made larger by default as well. The generic detector in ACTS, for example, uses between 1mm and 2mm, as far as I can see
I think that probably the envelopes on the telescope and toy detector should be made larger by default as well. The generic detector in ACTS, for example, uses between 1mm and 2mm, as far as I can see
Not necessary. This PR makes things OK as long as envelop size is larger than path tolerance which is in um scale
I think that probably the envelopes on the telescope and toy detector should be made larger by default as well. The generic detector in ACTS, for example, uses between 1mm and 2mm, as far as I can see
Not necessary. This PR makes things OK as long as envelop size is larger than path tolerance which is in um scale
Sure, but there is also no real reason to keep it that small and risk overlaps once we start experimenting with alignment corrections
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beomki-yeo
force-pushed
the
change-default-overstep
branch
2 times, most recently
from
From the study of acts-project/traccc#869
Also this seems working better with traccc tests when I just use default propagation config.
In case of initializing the candidate search at the new volume or beginning of the propagation, the path tolerance is used instead of overstep tolerance. Currently, there is a bug that track goes backward if it finds surface in opposite direction when
navigator::initis called at the very beginning of propagationFor example, in the telescope geometry whose envelope size is less than 1 mm, if I start the propagation at the first module, the track will just go back to the portal and terminate the propagation.