Use the default configs for the CKF & KF tests #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beomki-yeo
commented
Feb 26, 2025
|
The detray version is updated now |
|
|
Happy to approve, but we have to wait for the detray tag. |
beomki-yeo
commented
Mar 1, 2025
| @@ -13,7 +13,7 @@ message( STATUS "Building Detray as part of the TRACCC project" ) | |||
|
|
|||
| # Declare where to get Detray from. | |||
| set( TRACCC_DETRAY_SOURCE | |||
| "URL;https://github.com/acts-project/detray/archive/refs/tags/v0.88.1.tar.gz;URL_MD5;b4c1d2f4323d5e34d8964c6454c34983" | |||
| "URL;https://github.com/acts-project/detray/archive/refs/tags/v0.89.0.tar.gz;URL_MD5;98be1be806c52db1f6a17ccdc0495272" | |||
There was a problem hiding this comment.
It's updated already
|
@stephenswat @krasznaa Could you guys review? The detray tag has been updated |
stephenswat
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of hard-coded configuration parameters in CKF and KF tests are set to default values in this PR.
This can be merged once acts-project/detray#944 is merged and make a detray tag. (With the current
mainbranch, one of the KF tests is failed)