Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default configs for the CKF & KF tests #896

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Feb 26, 2025

Most of hard-coded configuration parameters in CKF and KF tests are set to default values in this PR.

This can be merged once acts-project/detray#944 is merged and make a detray tag. (With the current main branch, one of the KF tests is failed)

@beomki-yeo
Copy link
Contributor Author

The detray version is updated now

Copy link

sonarqubecloud bot commented Mar 1, 2025

@stephenswat
Copy link
Member

Happy to approve, but we have to wait for the detray tag.

@@ -13,7 +13,7 @@ message( STATUS "Building Detray as part of the TRACCC project" )

# Declare where to get Detray from.
set( TRACCC_DETRAY_SOURCE
"URL;https://github.com/acts-project/detray/archive/refs/tags/v0.88.1.tar.gz;URL_MD5;b4c1d2f4323d5e34d8964c6454c34983"
"URL;https://github.com/acts-project/detray/archive/refs/tags/v0.89.0.tar.gz;URL_MD5;98be1be806c52db1f6a17ccdc0495272"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated already

@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Mar 3, 2025

@stephenswat @krasznaa Could you guys review? The detray tag has been updated

@stephenswat stephenswat merged commit 2051f23 into acts-project:main Mar 3, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants