Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concepts for barrier-like types #602

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stephenswat
Copy link
Member

This commit continues my eternal crusade against unconstrained template types. It lays the groundwork for using concepts in traccc, and it adds a concept for barrier-like objects which are used in the CCL kernels as well as, possibly, other kernels in the future.

@stephenswat stephenswat added the feature New feature or request label May 31, 2024
@stephenswat
Copy link
Member Author

This depends on #599 so it can be tested in the CI.

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very on board with pushing forward with C++20. Just minor technical comments on my side.

stephenswat added a commit to stephenswat/traccc that referenced this pull request Jun 13, 2024
The version of clang-format that we use in this project is quite old
(version 10) and it is no longer able to properly format all of the new
stuff that has come into C++. See, for example, the formatting
nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to
clang-format 18.
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jun 13, 2024
The version of clang-format that we use in this project is quite old
(version 10) and it is no longer able to properly format all of the new
stuff that has come into C++. See, for example, the formatting
nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to
clang-format 18.
stephenswat added a commit to stephenswat/traccc that referenced this pull request Jun 20, 2024
The version of clang-format that we use in this project is quite old
(version 10) and it is no longer able to properly format all of the new
stuff that has come into C++. See, for example, the formatting
nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to
clang-format 18.
@stephenswat
Copy link
Member Author

Let's see what the new C++20 CI says. 😄

@stephenswat stephenswat marked this pull request as ready for review June 24, 2024 14:08
@stephenswat stephenswat marked this pull request as draft June 26, 2024 10:00
@stephenswat stephenswat marked this pull request as ready for review July 3, 2024 11:18
This commit lays the groundwork for using concepts in traccc, and it
adds a concept for barrier-like objects which are used in the CCL
kernels as well as, possibly, other kernels in the future.
@stephenswat stephenswat enabled auto-merge July 4, 2024 15:32
@stephenswat stephenswat merged commit 9b539bd into acts-project:main Jul 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants