-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add concepts for barrier-like types #602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on #599 so it can be tested in the CI. |
2ee1588
to
f4358ac
Compare
krasznaa
requested changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very on board with pushing forward with C++20. Just minor technical comments on my side.
f4358ac
to
d9a9733
Compare
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 13, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 13, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 20, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
d9a9733
to
5aacc87
Compare
Let's see what the new C++20 CI says. 😄 |
5aacc87
to
8da3d37
Compare
8da3d37
to
7313f89
Compare
7313f89
to
3f4e41c
Compare
paulgessinger
approved these changes
Jul 4, 2024
This commit lays the groundwork for using concepts in traccc, and it adds a concept for barrier-like objects which are used in the CCL kernels as well as, possibly, other kernels in the future.
3f4e41c
to
71a7266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit continues my eternal crusade against unconstrained template types. It lays the groundwork for using concepts in traccc, and it adds a concept for barrier-like objects which are used in the CCL kernels as well as, possibly, other kernels in the future.