Add sanity checks for contiguity and orderedness #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
feat/sanity_checks
branch
from
9d5f1fc to
e954fd1
Compare
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 13, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 13, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jun 20, 2024
The version of clang-format that we use in this project is quite old (version 10) and it is no longer able to properly format all of the new stuff that has come into C++. See, for example, the formatting nightmares in acts-project#609 and acts-project#602. This commit bumps the formatter up to clang-format 18.
stephenswat
force-pushed
the
feat/sanity_checks
branch
2 times, most recently
from
96de9ee to
1a140fd
Compare
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jul 16, 2024
The current CCA testing code for CUDA and SYCL is missing some necessary wait statements, which are causing me issues in acts-project#609. This commit fixes the problem by adding the missing waits.
stephenswat
force-pushed
the
feat/sanity_checks
branch
from
61fb0cf to
e4d192b
Compare
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Jul 16, 2024
The current CCA testing code for CUDA and SYCL is missing some necessary wait statements, which are causing me issues in acts-project#609. This commit fixes the problem by adding the missing waits.
stephenswat
force-pushed
the
feat/sanity_checks
branch
from
e4d192b to
5ef533c
Compare
|
Just to check: For being contiguous, is it required that unique ID is ordered? (In the measurement vector for track finding, the order of module ID does not really matter) |
Nope! It requires the IDs to be contiguous but not ordered. So an array |
beomki-yeo
reviewed
Jul 22, 2024
|
Sure, I'll add that. |
stephenswat
force-pushed
the
feat/sanity_checks
branch
from
5ef533c to
70ee2d6
Compare
|
@beomki-yeo I've added the CPU equivalents. |
stephenswat
force-pushed
the
feat/sanity_checks
branch
2 times, most recently
from
9d3dfa0 to
9b309fa
Compare
In some places, we rely on certain properties of our inputs. For one, we rely on our measurements being contiguous (with respect to the module identifiers) in the fitting code, and we rely on our cells being ordered in some way in the clustering code. I aim to emit properly contiguous elements from the CCL code in the future, but I want to make this process foolproof. To that end, I have added two new sanity checks which aim to find problems with input. One of them checks whether elements are contiguous (according to some projection function) and the other checks whether the elements are in some order. This commit also employs these checks for debug builds in some places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, we rely on certain properties of our inputs. For one, we rely on our measurements being contiguous (with respect to the module identifiers) in the fitting code, and we rely on our cells being ordered in some way in the clustering code. I aim to emit properly contiguous elements from the CCL code in the future, but I want to make this process foolproof. To that end, I have added two new sanity checks which aim to find problems with input. One of them checks whether elements are contiguous (according to some projection function) and the other checks whether the elements are in some order. This commit also employs these checks for debug builds in some places.