Add missing wait statements to CCA testing code #642
Conversation
stephenswat
added
bug
There was a problem hiding this comment.
I'm very surprised about your conclusion on this one. 🤔 Why should we need to wait on these operations? If anything, I would conclude that the setup(...) calls were missing ignore() calls. 🤔
These copies should be fine to be put into the same stream as the kernels that get launched after them. Why do we need synchronization points on them? 😕
There was a problem hiding this comment.
Ahh, never mind. The SYCL versions do need to be synchronized I guess. Since sycl::queue-s don't work quite in the same way as a CUDA stream. (Events are not necessarily ordered in them.) So the CUDA test could technically would just fine without these changes. It's only the SYCL test that is more finnicky. 🤔
But since we're only talking about some unit tests here, uniformity is probably more important to have.
The current CCA testing code for CUDA and SYCL is missing some necessary wait statements, which are causing me issues in acts-project#609. This commit fixes the problem by adding the missing waits.
stephenswat
force-pushed
the
fix/cca_test_missing_waits
branch
from
b19d265 to
90f85e3
Compare
The current CCA testing code for CUDA and SYCL is missing some necessary wait statements, which are causing me issues in #609. This commit fixes the problem by adding the missing waits.