Refactor the spacepoint formation

[beomki-yeo]

This are the changes that I have been suggesting for long time.

1. spacepoint_formation takes detray detector instead of detector description. Direct use of point_to_global with transform_matrix should be avoided. Most importantly, the local-to-global transformation of annulus shape (Polar coordinate) does not work with point_to_global which only works for Cartesian coordinate.

2. As detector description is not required (and should not be used), I moved its directory to seeding where the experimental::speacepoing_formation is located. This makes sense because spacepoints are technically only used for seeding.

+ Spacepoint formation is only applied to the 2D measurements as we do not support 1D measurements sp formation. Supporting 1D measurement will need to be followed up by further studies

Let me have 2D condition in the next PR (to test the performance without changing the actual results...)

[beomki-yeo]

As the spacepoint formation always require the detray geometry, the test files are changed to ODD from TML. The test compares the position of the found spacepoints (spacepoint_formation_algorithm) and truth spacepoints (hits.csv). Even though it is expected that there must be some deviations caused by the measurement_creation, the test requires about 20% uncertainties which is pretty bad. This probably explains the bad efficiency we have observed in the past - This needs to be followed up in the later PRs

[krasznaa]

It's not the greatest that we still have a lot of "if Detray detector then ..." checks in the code, but I think you're right. Let's be pragmatic, and just make the code work for now. It will indeed be better to get rid of the TML setup in follow-up steps.

Generally I'm happy with how you went about this, just had a couple of comments on a quick look. 🤔

[beomki-yeo]

The performance remains the same

Command

./bin/traccc_throughput_mt_cuda --detector-file=geometries/odd/odd-detray_geometry_detray.json --digitization-file=geometries/odd/odd-digi-geometric-config.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --use-detray-detector --input-directory=../../../../../../../bld6/data/traccc/geant4_ttbar_mu200/ --cpu-threads 2

Main

Reconstructed track parameters: 3299715
Time totals:
                  File reading  617 ms
            Warm-up processing  147130 ms
              Event processing  4809 ms
Throughput:
            Warm-up processing  14713 ms/event, 0.067967 events/s
              Event processing  48.0923 ms/event, 20.7934 events/s

PR

Reconstructed track parameters: 3299774
Time totals:
                  File reading  618 ms
            Warm-up processing  938 ms
              Event processing  4811 ms
Throughput:
            Warm-up processing  93.8457 ms/event, 10.6558 events/s
              Event processing  48.1174 ms/event, 20.7825 events/s

[krasznaa]

Okay, let's go like this for now. As I'm on board with the overall direction.