Fix register overload in CUDA spacepoint formation #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
force-pushed
the
fix/cuda_sp_launch_bounds
branch
from
5ad8c42 to
23d73a2
Compare
krasznaa
reviewed
Oct 8, 2024
krasznaa
approved these changes
Oct 8, 2024
stephenswat
force-pushed
the
fix/cuda_sp_launch_bounds
branch
from
23d73a2 to
f10c2cf
Compare
stephenswat
force-pushed
the
fix/cuda_sp_launch_bounds
branch
from
f10c2cf to
b47338d
Compare
|
PR acts-project#719 refactored the spacepoint formation to use the detray detector. While this was and remains a good idea, the introduction of the detray detector massively increases the register use of the kernel, to the point that I was seeing "too many resources requested for launch" errors. This commit modifies the kernel to specify appropriate launch bounds, allowing the compiler to better tune the register usage and resolve the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #719 refactored the spacepoint formation to use the detray detector. While this was and remains a good idea, the introduction of the detray detector massively increases the register use of the kernel, to the point that I was seeing "too many resources requested for launch" errors. This commit modifies the kernel to specify appropriate launch bounds, allowing the compiler to better tune the register usage and resolve the bug.