Digitization Config JSON I/O Update, main branch (2024.11.14.) #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasznaa
added
feature
At the same time moved the JSON reading code to be more in line with how we have the CSV and OBJ file reading/writing code in the library.
krasznaa
force-pushed
the
JsonIO-main-20241114
branch
from
fdc784d to
f473552
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to write
traccc::digitization_configto JSON files. This is in a hope that @nribaric will be able to use this code to write a (possibly very large) ITk digitization file using Athena. 🤔 So that we could attempt ITk studies outside Athena as well. 😉At the same time moved the JSON reading code to be more in line with how we have the CSV and OBJ file reading/writing code in the library.