Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitization Config JSON I/O Update, main branch (2024.11.14.) #772

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

krasznaa
Copy link
Member

Added the ability to write traccc::digitization_config to JSON files. This is in a hope that @nribaric will be able to use this code to write a (possibly very large) ITk digitization file using Athena. 🤔 So that we could attempt ITk studies outside Athena as well. 😉

At the same time moved the JSON reading code to be more in line with how we have the CSV and OBJ file reading/writing code in the library.

@krasznaa krasznaa added feature New feature or request tests Make sure the code keeps working improvement Improve an existing feature labels Nov 14, 2024
At the same time moved the JSON reading code to be more in line with
how we have the CSV and OBJ file reading/writing code in the library.
@krasznaa krasznaa force-pushed the JsonIO-main-20241114 branch from fdc784d to f473552 Compare November 14, 2024 13:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@krasznaa krasznaa merged commit 25c71d4 into acts-project:main Nov 15, 2024
25 of 26 checks passed
@krasznaa krasznaa deleted the JsonIO-main-20241114 branch November 15, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improvement Improve an existing feature tests Make sure the code keeps working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants