-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell CSV Writing, main branch (2024.11.20.) #777
Cell CSV Writing, main branch (2024.11.20.) #777
Conversation
While also adding a unit test for that code.
ab8bcf4
to
b19b027
Compare
SonarCloud may complain, but I'm absolutely happy using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks reasonable to me
|
* Implemented cell CSV writing. While also adding a unit test for that code. * Made it possible to write Detray geometry IDs with the cells. * Made it possible to read cells with "Detray geometry IDs". * Make the test a little more robust against errors.
Following up from #772, in order for @paradajzblond (Neza's actual username... 😛) to be able to write ITk cell info in Athena, I taught
traccc::io
how to writetraccc::edm::silicon_cell_collection
into CSV files.