Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell CSV Writing, main branch (2024.11.20.) #777

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

krasznaa
Copy link
Member

Following up from #772, in order for @paradajzblond (Neza's actual username... 😛) to be able to write ITk cell info in Athena, I taught traccc::io how to write traccc::edm::silicon_cell_collection into CSV files.

While also adding a unit test for that code.
@krasznaa krasznaa added the feature New feature or request label Nov 20, 2024
@krasznaa krasznaa force-pushed the CellCSVWriting-main-20241120 branch from ab8bcf4 to b19b027 Compare November 20, 2024 14:32
@krasznaa krasznaa marked this pull request as ready for review November 20, 2024 14:33
@krasznaa
Copy link
Member Author

SonarCloud may complain, but I'm absolutely happy using std::filesystem::temp_directory_path() in our unit tests... So I consider the PR ready.

Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks reasonable to me

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@krasznaa krasznaa enabled auto-merge (squash) November 20, 2024 15:44
@krasznaa krasznaa merged commit 6ba5c07 into acts-project:main Nov 20, 2024
25 of 26 checks passed
@krasznaa krasznaa deleted the CellCSVWriting-main-20241120 branch November 20, 2024 17:14
flg pushed a commit to flg/traccc that referenced this pull request Nov 26, 2024
* Implemented cell CSV writing.

While also adding a unit test for that code.

* Made it possible to write Detray geometry IDs with the cells.

* Made it possible to read cells with "Detray geometry IDs".

* Make the test a little more robust against errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants