Cell CSV Writing, main branch (2024.11.20.) #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While also adding a unit test for that code.
krasznaa
force-pushed
the
CellCSVWriting-main-20241120
branch
from
ab8bcf4 to
b19b027
Compare
|
SonarCloud may complain, but I'm absolutely happy using |
beomki-yeo
approved these changes
Nov 20, 2024
|
flg
pushed a commit
to flg/traccc
that referenced
this pull request
Nov 26, 2024
* Implemented cell CSV writing. While also adding a unit test for that code. * Made it possible to write Detray geometry IDs with the cells. * Made it possible to read cells with "Detray geometry IDs". * Make the test a little more robust against errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from #772, in order for @paradajzblond (Neza's actual username... 😛) to be able to write ITk cell info in Athena, I taught
traccc::iohow to writetraccc::edm::silicon_cell_collectioninto CSV files.