Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Reference Fixes, main branch (2024.12.02.) #791

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

krasznaa
Copy link
Member

@krasznaa krasznaa commented Dec 2, 2024

Make atomic references use correct address spaces in the track finding device code.

With CUDA there is no difference in the API for using atomic operations on global or local/shared memory. But with SYCL there is. So this is a necessary update for #773. (But also, if we ever start using cuda::atomic_ref behind vecmem::device_atomic_ref, this may become relevant for CUDA as well. 🤔 Maybe...

@krasznaa krasznaa added the bug Something isn't working label Dec 2, 2024
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense. 👍

With CUDA there is no difference in the API for using
atomic operations on global or shared memory. But with
SYCL there is...
@krasznaa krasznaa force-pushed the AtomicRefFixes-main-20241202 branch from be8fc3c to 7e232c1 Compare December 2, 2024 21:02
Copy link

sonarqubecloud bot commented Dec 2, 2024

@krasznaa krasznaa enabled auto-merge December 2, 2024 21:12
@krasznaa krasznaa merged commit b2e3ef7 into acts-project:main Dec 2, 2024
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants