Atomic Reference Fixes, main branch (2024.12.02.) #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With CUDA there is no difference in the API for using atomic operations on global or shared memory. But with SYCL there is...
krasznaa
force-pushed
the
AtomicRefFixes-main-20241202
branch
from
be8fc3c to
7e232c1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make atomic references use correct address spaces in the track finding device code.
With CUDA there is no difference in the API for using atomic operations on global or local/shared memory. But with SYCL there is. So this is a necessary update for #773. (But also, if we ever start using cuda::atomic_ref behind
vecmem::device_atomic_ref, this may become relevant for CUDA as well. 🤔 Maybe...