Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Reference Fixes, main branch (2024.12.02.) #791

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions device/common/include/traccc/finding/device/impl/find_tracks.ipp
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ TRACCC_DEVICE inline void find_tracks(
vecmem::device_vector<unsigned int> out_params_liveness(
payload.out_params_liveness_view);
vecmem::device_vector<candidate_link> links(payload.links_view);
vecmem::device_atomic_ref<unsigned int> num_total_candidates(
*payload.n_total_candidates);
vecmem::device_atomic_ref<unsigned int,
vecmem::device_address_space::global>
num_total_candidates(*payload.n_total_candidates);
vecmem::device_vector<const detray::geometry::barcode> barcodes(
payload.barcodes_view);
vecmem::device_vector<const unsigned int> upper_bounds(
Expand Down Expand Up @@ -155,9 +156,11 @@ TRACCC_DEVICE inline void find_tracks(
for (; curr_meas < num_meas &&
shared_payload.shared_candidates_size < thread_id.getBlockDimX();
curr_meas++) {
unsigned int idx = vecmem::device_atomic_ref<unsigned int>(
shared_payload.shared_candidates_size)
.fetch_add(1u);
unsigned int idx =
vecmem::device_atomic_ref<unsigned int,
vecmem::device_address_space::local>(
shared_payload.shared_candidates_size)
.fetch_add(1u);

/*
* The buffer elemements are tuples of the measurement index and
Expand Down Expand Up @@ -226,7 +229,8 @@ TRACCC_DEVICE inline void find_tracks(

// Increase the number of candidates (or branches) per input
// parameter
vecmem::device_atomic_ref<unsigned int>(
vecmem::device_atomic_ref<
unsigned int, vecmem::device_address_space::local>(
shared_payload
.shared_num_candidates[owner_local_thread_id])
.fetch_add(1u);
Expand Down
Loading