Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-track edge case bug in CUDA track finding #825

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

stephenswat
Copy link
Member

This commit fixes a bug discovered by Neza; if the track finding finds exactly zero tips, it never sets the total number of track candidates to zero, which causes it to use an uninitialized value in a later kernel. This, in turn, leads to an assertion error. In this commit, we fix the bug and add an assertion to protect against any future errors.

This commit fixes a bug discovered by Neza; if the track finding finds
exactly zero tips, it never sets the total number of track candidates to
zero, which causes it to use an uninitialized value in a later kernel.
This, in turn, leads to an assertion error. In this commit, we fix the
bug and add an assertion to protect against any future errors.

Co-authored-by: Neža Ribarič <neza.ribaric@cern.ch>
@stephenswat stephenswat added bug Something isn't working cuda Changes related to CUDA labels Jan 29, 2025
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to say that you should fix this in the SYCL code as well. But apparently I did.

https://github.com/acts-project/traccc/blob/main/device/sycl/src/finding/find_tracks.hpp#L459

And then I didn't put 1+1 together that this would need to be done correctly with CUDA as well... 😭

@stephenswat stephenswat merged commit af26461 into acts-project:main Jan 29, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda Changes related to CUDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants