Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-track edge case bug in CUDA track finding #825

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix zero-track edge case bug in CUDA track finding #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions device/common/include/traccc/finding/device/impl/prune_tracks.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ TRACCC_DEVICE inline void prune_tracks(const global_index_t globalIndex,
track_candidate_container_types::device prune_candidates(
payload.prune_candidates_view);

assert(valid_indices.size() == prune_candidates.size());

if (globalIndex >= prune_candidates.size()) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion device/cuda/src/finding/finding_algorithm.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ finding_algorithm<stepper_t, navigator_t>::operator()(
vecmem::data::vector_buffer<unsigned int> valid_indices_buffer(n_tips_total,
m_mr.main);

unsigned int n_valid_tracks;
unsigned int n_valid_tracks = 0;

// @Note: nBlocks can be zero in case there is no tip. This happens when
// chi2_max config is set tightly and no tips are found
Expand Down
Loading