Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug in getting the first smoother state #863

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Feb 12, 2025

A little bit critial bug.. when the measurement of the last track state is not found during the forward filtering

After merging #862, we will need to return false in smoothe if all track states are holes.

@beomki-yeo beomki-yeo marked this pull request as draft February 12, 2025 17:30
@beomki-yeo beomki-yeo added the bug Something isn't working label Feb 12, 2025
Copy link
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@beomki-yeo beomki-yeo force-pushed the fix-smoother-error branch 2 times, most recently from 04b2a48 to cd78ca3 Compare February 13, 2025 20:57
@beomki-yeo beomki-yeo marked this pull request as ready for review February 13, 2025 20:57
@beomki-yeo beomki-yeo force-pushed the fix-smoother-error branch 2 times, most recently from 43615b9 to 7bb130f Compare February 13, 2025 22:45
Copy link

@beomki-yeo beomki-yeo merged commit 4d23077 into acts-project:main Feb 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants