-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure propagation to Kálmán filter code #862
Add failure propagation to Kálmán filter code #862
Conversation
31f3038
to
d439f0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I would like to understand the situation as I am also debugging the smoother
core/include/traccc/fitting/kalman_filter/gain_matrix_smoother.hpp
Outdated
Show resolved
Hide resolved
d439f0b
to
8f8a432
Compare
8f8a432
to
c49d247
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be merged soon
c49d247
to
e37a579
Compare
It seems the smoother used in the wire chamber fitting is failing - I think It is OK to change the requirement to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You guys will have to sort out the technical details, but just to say, I'm very on board with these code changes. 😉
fd85313
to
7ee8338
Compare
This commit enables our Kálmán filter code to fail, e.g. it allows the smoothers and updaters to return a success value, and that success value is returned to the outside algorithm. This allows us to elegantly handle edge cases like those described in acts-project#858, as well as cases where tracks propagate exactly along the z-axis. Co-authored-by: Beomki Yeo <beomki.yeo@gmail.com>
7ee8338
to
593f31f
Compare
|
This commit enables our Kálmán filter code to fail, e.g. it allows the smoothers and updaters to return a success value, and that success value is returned to the outside algorithm. This allows us to elegantly handle edge cases like those described in #858, as well as cases where tracks propagate exactly along the z-axis. Some of this code taken from #781, thanks @beomki-yeo.