Add failure propagation to Kálmán filter code #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
improvement
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
from
31f3038 to
d439f0b
Compare
beomki-yeo
reviewed
Feb 12, 2025
core/include/traccc/fitting/kalman_filter/gain_matrix_smoother.hpp
Outdated
Show resolved
Hide resolved
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
from
d439f0b to
8f8a432
Compare
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
from
8f8a432 to
c49d247
Compare
beomki-yeo
approved these changes
Feb 17, 2025
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
from
c49d247 to
e37a579
Compare
|
It seems the smoother used in the wire chamber fitting is failing - I think It is OK to change the requirement to |
krasznaa
reviewed
Feb 18, 2025
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
2 times, most recently
from
fd85313 to
7ee8338
Compare
This commit enables our Kálmán filter code to fail, e.g. it allows the smoothers and updaters to return a success value, and that success value is returned to the outside algorithm. This allows us to elegantly handle edge cases like those described in acts-project#858, as well as cases where tracks propagate exactly along the z-axis. Co-authored-by: Beomki Yeo <beomki.yeo@gmail.com>
stephenswat
force-pushed
the
impr/fit_failure_prop
branch
from
7ee8338 to
593f31f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables our Kálmán filter code to fail, e.g. it allows the smoothers and updaters to return a success value, and that success value is returned to the outside algorithm. This allows us to elegantly handle edge cases like those described in #858, as well as cases where tracks propagate exactly along the z-axis. Some of this code taken from #781, thanks @beomki-yeo.