Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure propagation to Kálmán filter code #862

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

stephenswat
Copy link
Member

@stephenswat stephenswat commented Feb 12, 2025

This commit enables our Kálmán filter code to fail, e.g. it allows the smoothers and updaters to return a success value, and that success value is returned to the outside algorithm. This allows us to elegantly handle edge cases like those described in #858, as well as cases where tracks propagate exactly along the z-axis. Some of this code taken from #781, thanks @beomki-yeo.

@stephenswat stephenswat added improvement Improve an existing feature shared Changes related to shared code labels Feb 12, 2025
@stephenswat stephenswat force-pushed the impr/fit_failure_prop branch from 31f3038 to d439f0b Compare February 12, 2025 17:19
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would like to understand the situation as I am also debugging the smoother

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged soon

@stephenswat stephenswat force-pushed the impr/fit_failure_prop branch from c49d247 to e37a579 Compare February 17, 2025 13:27
@beomki-yeo
Copy link
Contributor

It seems the smoother used in the wire chamber fitting is failing - I think It is OK to change the requirement to
ASSERT_NEAR(n_tracks, n_truth_tracks, n_truth_tracks * 0.02) to pass the test

Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guys will have to sort out the technical details, but just to say, I'm very on board with these code changes. 😉

@stephenswat stephenswat force-pushed the impr/fit_failure_prop branch 2 times, most recently from fd85313 to 7ee8338 Compare February 19, 2025 12:34
This commit enables our Kálmán filter code to fail, e.g. it allows the
smoothers and updaters to return a success value, and that success value
is returned to the outside algorithm. This allows us to elegantly handle
edge cases like those described in acts-project#858, as well as cases where tracks
propagate exactly along the z-axis.

Co-authored-by: Beomki Yeo <beomki.yeo@gmail.com>
@stephenswat stephenswat force-pushed the impr/fit_failure_prop branch from 7ee8338 to 593f31f Compare February 19, 2025 12:54
@stephenswat stephenswat merged commit f7f5e0b into acts-project:main Feb 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve an existing feature shared Changes related to shared code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants