ref: Measure wall time in multithreaded benchmark and reduce number of events #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if #862 will solve the current issue with benchmark. If it does, we don't have to change the setup |
beomki-yeo
approved these changes
Feb 19, 2025
|
|
The benchmark still fails.. have you tested it? |
Hm, yes, I tried the CPU benchmark again just now and on my local machine its still fine... |
|
It's also seg fault in my setup |
|
Sounds like undefined behavior. I am trying a debug run now, but that will take some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get an accurate result in a multithreaded benchmark, measure the wall clock time.
Until we find out, why the benchmark produces a segmentation fault, I have reduced the number of events, so that it at least runs. At the same time, I also increased the number of tracks per event to simulate higher pileup