Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Measure wall time in multithreaded benchmark and reduce number of events #872

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

niermann999
Copy link
Contributor

To get an accurate result in a multithreaded benchmark, measure the wall clock time.
Until we find out, why the benchmark produces a segmentation fault, I have reduced the number of events, so that it at least runs. At the same time, I also increased the number of tracks per event to simulate higher pileup

@niermann999 niermann999 added the bug Something isn't working label Feb 17, 2025
@beomki-yeo
Copy link
Contributor

Let's see if #862 will solve the current issue with benchmark. If it does, we don't have to change the setup

@beomki-yeo beomki-yeo merged commit ce80a7e into acts-project:main Feb 19, 2025
29 checks passed
@beomki-yeo
Copy link
Contributor

The benchmark still fails.. have you tested it?
https://gitlab.cern.ch/acts/traccc-benchmark/-/jobs/51326838

@niermann999
Copy link
Contributor Author

The benchmark still fails.. have you tested it? https://gitlab.cern.ch/acts/traccc-benchmark/-/jobs/51326838

Hm, yes, I tried the CPU benchmark again just now and on my local machine its still fine...

@beomki-yeo
Copy link
Contributor

It's also seg fault in my setup

@niermann999
Copy link
Contributor Author

Sounds like undefined behavior. I am trying a debug run now, but that will take some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants