Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Harmonize track parameters types #867

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

niermann999
Copy link
Contributor

Use the traccc track parameter types everywhere and allow templating of the algebra type

@niermann999 niermann999 added the cleanup Makes the code all clean and tidy label Feb 13, 2025
@niermann999 niermann999 force-pushed the ref-track-parameters branch 8 times, most recently from 84b5703 to acd1c62 Compare February 14, 2025 22:22
Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to allow other algebras? @stephenswat @krasznaa
TBH, I would like to focus on the development of default algebra

@niermann999 niermann999 force-pushed the ref-track-parameters branch 5 times, most recently from 81638a3 to 1b7f0b6 Compare February 17, 2025 08:53
@krasznaa
Copy link
Member

Do we still want to allow other algebras? @stephenswat @krasznaa TBH, I would like to focus on the development of default algebra

It's not a black or white thing in my eyes. But in end effect, I believe we should be going this way, yes. I'm very much on board with making it possible to use different algebras in the code.

With that being said, the final code, in 1-2 year's time, may not use quote so much templating. But for now, I believe this is the way to go. 🤔

@niermann999 niermann999 force-pushed the ref-track-parameters branch 3 times, most recently from f60443c to 5590d65 Compare February 20, 2025 19:21
@stephenswat stephenswat enabled auto-merge (squash) February 21, 2025 13:13
@stephenswat stephenswat merged commit 69c1ef6 into acts-project:main Feb 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Makes the code all clean and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants