Add pre-commit hook to check for detray units #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
approved these changes
Feb 21, 2025
stephenswat
force-pushed
the
ci/check_taboos
branch
from
a43f7c4 to
c7d01e1
Compare
|
I added the track parameters too, so this now depends on #867. |
stephenswat
force-pushed
the
ci/check_taboos
branch
from
c7d01e1 to
51e22ad
Compare
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876) that ensures that we don't re-introduce uses of the `detray::unit` and `detray::constant` namespaces. Can be extended in the future to hold more patterns if desired.
stephenswat
force-pushed
the
ci/check_taboos
branch
from
51e22ad to
e403c79
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a little pre-commit hook (inspired by #866 and #876) that ensures that we don't re-introduce uses of the
detray::unitanddetray::constantnamespaces. Can be extended in the future to hold more patterns if desired.Depends on #876.