Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove detray unit types #876

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Feb 19, 2025

Remove some more detray units and set the rk-tolerance to mm, which internally it already seems to be

@niermann999 niermann999 added the cleanup Makes the code all clean and tidy label Feb 19, 2025
@niermann999 niermann999 force-pushed the ref-traccc-units branch 2 times, most recently from 85ef0c5 to 20d01eb Compare February 19, 2025 16:40
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... 🤔

@stephenswat
Copy link
Member

A pre-commit check to ensure we don't re-introduce these detray namespaces would be nice... 😄

stephenswat added a commit to stephenswat/traccc that referenced this pull request Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876)
that ensures that we don't re-introduce uses of the `detray::unit` and
`detray::constant` namespaces. Can be extended in the future to hold
more patterns if desired.
@stephenswat stephenswat enabled auto-merge (squash) February 21, 2025 11:56
stephenswat added a commit to stephenswat/traccc that referenced this pull request Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876)
that ensures that we don't re-introduce uses of the `detray::unit` and
`detray::constant` namespaces. Can be extended in the future to hold
more patterns if desired.
@stephenswat stephenswat merged commit f2d66f1 into acts-project:main Feb 21, 2025
28 of 29 checks passed
stephenswat added a commit to stephenswat/traccc that referenced this pull request Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876)
that ensures that we don't re-introduce uses of the `detray::unit` and
`detray::constant` namespaces. Can be extended in the future to hold
more patterns if desired.
stephenswat added a commit to stephenswat/traccc that referenced this pull request Feb 24, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876)
that ensures that we don't re-introduce uses of the `detray::unit` and
`detray::constant` namespaces. Can be extended in the future to hold
more patterns if desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Makes the code all clean and tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants