ref: Remove detray unit types #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
ref-traccc-units
branch
2 times, most recently
from
85ef0c5 to
20d01eb
Compare
beomki-yeo
reviewed
Feb 20, 2025
niermann999
force-pushed
the
ref-traccc-units
branch
from
20d01eb to
2811503
Compare
|
A pre-commit check to ensure we don't re-introduce these detray namespaces would be nice... 😄 |
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876) that ensures that we don't re-introduce uses of the `detray::unit` and `detray::constant` namespaces. Can be extended in the future to hold more patterns if desired.
|
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876) that ensures that we don't re-introduce uses of the `detray::unit` and `detray::constant` namespaces. Can be extended in the future to hold more patterns if desired.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 21, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876) that ensures that we don't re-introduce uses of the `detray::unit` and `detray::constant` namespaces. Can be extended in the future to hold more patterns if desired.
stephenswat
added a commit
to stephenswat/traccc
that referenced
this pull request
Feb 24, 2025
This commit adds a little pre-commit hook (inspired by acts-project#866 and acts-project#876) that ensures that we don't re-introduce uses of the `detray::unit` and `detray::constant` namespaces. Can be extended in the future to hold more patterns if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some more detray units and set the rk-tolerance to mm, which internally it already seems to be