make BudgetTable Budgeted value positive on mobile (#3602)

* make BudgetTable Budgeted value positive on mobile To match the desktop behaviour. * add release notes * update vrt snapshots * fix tracking budget
actualbudget · Oct 14, 2024 · e0f0d8e · e0f0d8e
1 parent 310d299
commit e0f0d8e
Show file tree

Hide file tree

Showing 25 changed files with 8 additions and 2 deletions.
diff --git a/...cking--14404-in-the-page-header-opens-the-month-menu-modal-3-chromium-linux.png b/...cking--14404-in-the-page-header-opens-the-month-menu-modal-3-chromium-linux.png
diff --git a/...cking--4bb70-ed-amount-opens-the-budget-summary-menu-modal-1-chromium-linux.png b/...cking--4bb70-ed-amount-opens-the-budget-summary-menu-modal-1-chromium-linux.png
diff --git a/...cking--6ab37-roup-name-opens-the-category-group-menu-modal-1-chromium-linux.png b/...cking--6ab37-roup-name-opens-the-category-group-menu-modal-1-chromium-linux.png
diff --git a/...cking--6dbdb-page-header-shows-the-previous-month-s-budget-1-chromium-linux.png b/...cking--6dbdb-page-header-shows-the-previous-month-s-budget-1-chromium-linux.png
diff --git a/...cking--94a85-ed-amount-opens-the-budget-summary-menu-modal-3-chromium-linux.png b/...cking--94a85-ed-amount-opens-the-budget-summary-menu-modal-3-chromium-linux.png
diff --git a/...cking--96ebb-page-header-shows-the-previous-month-s-budget-3-chromium-linux.png b/...cking--96ebb-page-header-shows-the-previous-month-s-budget-3-chromium-linux.png
diff --git a/...cking--9e6aa-in-the-page-header-opens-the-budget-page-menu-1-chromium-linux.png b/...cking--9e6aa-in-the-page-header-opens-the-budget-page-menu-1-chromium-linux.png
diff --git a/...cking--bbde3-roup-name-opens-the-category-group-menu-modal-3-chromium-linux.png b/...cking--bbde3-roup-name-opens-the-category-group-menu-modal-3-chromium-linux.png
diff --git a/...cking--bed18-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png b/...cking--bed18-in-the-page-header-opens-the-month-menu-modal-1-chromium-linux.png
diff --git a/...cking--d7184-page-header-shows-the-previous-month-s-budget-2-chromium-linux.png b/...cking--d7184-page-header-shows-the-previous-month-s-budget-2-chromium-linux.png
diff --git a/...cking--fdd57-in-the-page-header-opens-the-budget-page-menu-3-chromium-linux.png b/...cking--fdd57-in-the-page-header-opens-the-budget-page-menu-3-chromium-linux.png
diff --git a/...hat-clicking-the-balance-cell-opens-the-balance-menu-modal-1-chromium-linux.png b/...hat-clicking-the-balance-cell-opens-the-balance-menu-modal-1-chromium-linux.png
diff --git a/...hat-clicking-the-balance-cell-opens-the-balance-menu-modal-3-chromium-linux.png b/...hat-clicking-the-balance-cell-opens-the-balance-menu-modal-3-chromium-linux.png
diff --git a/...hat-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png b/...hat-clicking-the-budgeted-cell-opens-the-budget-menu-modal-1-chromium-linux.png
diff --git a/...hat-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png b/...hat-clicking-the-budgeted-cell-opens-the-budget-menu-modal-3-chromium-linux.png
diff --git a/...t-clicking-the-category-name-opens-the-category-menu-modal-1-chromium-linux.png b/...t-clicking-the-category-name-opens-the-category-menu-modal-1-chromium-linux.png
diff --git a/...t-clicking-the-category-name-opens-the-category-menu-modal-3-chromium-linux.png b/...t-clicking-the-category-name-opens-the-category-menu-modal-3-chromium-linux.png
diff --git a/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-1-chromium-linux.png b/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-1-chromium-linux.png
diff --git a/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png b/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png
diff --git a/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-3-chromium-linux.png b/...udget-Envelope-loads-the-budget-page-with-budgeted-amounts-3-chromium-linux.png
diff --git a/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-1-chromium-linux.png b/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-1-chromium-linux.png
diff --git a/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-2-chromium-linux.png b/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-2-chromium-linux.png
diff --git a/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-3-chromium-linux.png b/...apshots/Mobile-Budget-Envelope-updates-the-budgeted-amount-3-chromium-linux.png
diff --git a/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx b/packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx
@@ -1793,7 +1793,7 @@ function BudgetTableHeader({
             }
             type="financial"
           >
-            {({ type, value }) => (
+            {({ type: formatType, value }) => (
               <Button
                 variant="bare"
                 isDisabled={show3Cols}
@@ -1834,7 +1834,7 @@ function BudgetTableHeader({
                           paddingRight: 4,
                         }}
                       >
-                        {format(value, type)}
+                        {format(type === 'report' ? value : -value, formatType)}
                       </AutoTextSize>
                     </PrivacyFilter>
                   </View>

diff --git a/upcoming-release-notes/3602.md b/upcoming-release-notes/3602.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [tim-smart]
+---
+
+Ensure budgeted amounts are positive for mobile budget view