make BudgetTable Budgeted value positive on mobile #3602

tim-smart · 2024-10-08T01:37:52Z

To match the desktop behaviour.

netlify · 2024-10-08T01:38:09Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`31fc051`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/6705e136800ce700080b0a75
😎 Deploy Preview	https://deploy-preview-3602.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-10-08T01:39:05Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.32 MB → 5.32 MB (+39 B)	+0.00%

Changeset

File	Δ	Size
`src/components/mobile/budget/BudgetTable.jsx`	📈 +39 B (+0.07%)	53.33 kB → 53.37 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/narrow.js	82.55 kB → 82.58 kB (+39 B)	+0.05%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/AppliedFilters.js	20.96 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/wide.js	224.88 kB	0%
static/js/ReportRouter.js	1.51 MB	0%
static/js/index.js	3.34 MB	0%

github-actions · 2024-10-08T01:39:06Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.26 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.26 MB	0%

coderabbitai · 2024-10-08T01:41:28Z

Walkthrough

The changes in this pull request focus on the BudgetTable.jsx component within the desktop client. The primary modification involves the formatting of the budgeted amount in the BudgetTableHeader function, where the budgeted value is now negated when the type is not 'report', changing from format(value, type) to format(type === 'report' ? value : -value, formatType). This adjustment alters how the budgeted amount is displayed. Additionally, minor structural updates have been made to the destructured parameters in the CellValue component, changing type to formatType. The pull request also includes layout and presentation adjustments across various components, such as BudgetGroups, IncomeGroup, ExpenseGroup, Saved, and ToBudget, ensuring consistency in the user interface. The overall functionality and data handling of the component remain unchanged, with no modifications to the declarations of exported or public entities.

Possibly related PRs

fix modals on mobile BudgetTable #3487: This PR modifies the BudgetTable.jsx component, specifically changing how budget types are referenced, which may relate to the overall structure and functionality of the BudgetTable component in the main PR.
[Mobile] Update to Budgeted to match the column name in mobile budget table #3573: This PR updates the terminology in the EnvelopeBudgetMenuModal and TrackingBudgetMenuModal components to ensure consistency with the mobile budget table, which is relevant to the changes made in the BudgetTable.jsx regarding budget representation.
[Mobile] Fix budget list on mobile auto selecting a budget file under the Switch budget file menu #3574: This PR addresses issues related to the budget list functionality on mobile devices, which could be indirectly related to the user interface adjustments made in the BudgetTable component.

Suggested labels

:sparkles: Merged

Suggested reviewers

youngcw

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4f9ed5c and 8854952.

📒 Files selected for processing (1)

packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (2)

Line range hint 1-1837: Consider revisiting commented-out drag-and-drop functionality.

There are several sections of commented-out code related to drag-and-drop functionality throughout the file. It might be worth investigating whether this functionality is still needed or if it can be safely removed to improve code clarity.

Line range hint 1-1837: Consider splitting the file into smaller components.

This file is quite large and contains multiple components related to the budget table functionality. To improve maintainability and readability, consider splitting this file into smaller, more focused components. This would make the code easier to navigate and maintain in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bdeb194 and 7b9d5b0.

📒 Files selected for processing (1)

packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (1)

1837-1837: LGTM: Budgeted value now displayed as positive.

The change from format(value, type) to format(-value, type) successfully implements the PR objective of making the Budgeted value positive on mobile. This change ensures consistency with the desktop version and improves the user experience.

tim-smart · 2024-10-08T01:54:56Z

Hmm vrt should have failed.

joel-jeremy · 2024-10-08T14:46:48Z

Hmm vrt should have failed.

Agreed Do you mind checking the VRT why it's not failing? It should be in budget.mobile.test.js file.

youngcw · 2024-10-08T15:00:36Z

My guess is that since the change is so small it came in under the threshold of allowed difference.

tim-smart · 2024-10-09T01:35:20Z

Temporarily dropping the threshold did the trick.

To match the desktop behaviour.

actual-github-bot bot changed the title ~~make BudgetTable Budgeted value positive on mobile~~ [WIP] make BudgetTable Budgeted value positive on mobile Oct 8, 2024

actual-github-bot bot added the 🚧 WIP label Oct 8, 2024

coderabbitai bot reviewed Oct 8, 2024

View reviewed changes

tim-smart changed the title ~~[WIP] make BudgetTable Budgeted value positive on mobile~~ make BudgetTable Budgeted value positive on mobile Oct 8, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Oct 8, 2024

tim-smart force-pushed the mobile-budgeted branch from ac8ba3e to 9a93e46 Compare October 8, 2024 02:26

tim-smart force-pushed the mobile-budgeted branch from 8854952 to 5032b37 Compare October 9, 2024 01:49

tim-smart added 4 commits October 9, 2024 14:49

make BudgetTable Budgeted value positive on mobile

5f72a01

To match the desktop behaviour.

add release notes

635fe1f

update vrt snapshots

ac4b495

fix tracking budget

31fc051

tim-smart force-pushed the mobile-budgeted branch from 5032b37 to 31fc051 Compare October 9, 2024 01:49

joel-jeremy approved these changes Oct 14, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Oct 14, 2024

joel-jeremy merged commit e0f0d8e into actualbudget:master Oct 14, 2024
20 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Oct 14, 2024

This was referenced Oct 14, 2024

[e2e] Mobile budget menu modal VRT #3583

Open

Fix wrong scheduled transfer payment direction on PWA #3402

Merged

coderabbitai bot mentioned this pull request Oct 24, 2024

fix modal scrolling performance on mobile #3343

Merged

coderabbitai bot mentioned this pull request Oct 24, 2024

Fix loading of mobile/desktop page on window resize #3729

Merged

This was referenced Nov 3, 2024

Fix mobile navigation tabs expanding/collapsing when scrolling in modals #3731

Merged

Convert Mobile Transaction component to TransactionListItem + cleanup #3761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make BudgetTable Budgeted value positive on mobile #3602

make BudgetTable Budgeted value positive on mobile #3602

tim-smart commented Oct 8, 2024

netlify bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

coderabbitai bot commented Oct 8, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

tim-smart commented Oct 8, 2024

joel-jeremy commented Oct 8, 2024

youngcw commented Oct 8, 2024

tim-smart commented Oct 9, 2024

make BudgetTable Budgeted value positive on mobile #3602

make BudgetTable Budgeted value positive on mobile #3602

Conversation

tim-smart commented Oct 8, 2024

netlify bot commented Oct 8, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Oct 8, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Oct 8, 2024 • edited Loading

Bundle Stats — loot-core

coderabbitai bot commented Oct 8, 2024 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

tim-smart commented Oct 8, 2024

joel-jeremy commented Oct 8, 2024

youngcw commented Oct 8, 2024

tim-smart commented Oct 9, 2024

netlify bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

coderabbitai bot commented Oct 8, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)