Skip to content

Conversation

@sommersoft
Copy link
Collaborator

During validate_contents, the check to make sure each example is prefixed with the library name, the repo's name was used. The rfind() was set to look for the first _, which resulted in errors when the repo had an extra underscore beyond CircuitPython. Example: Adafruit_CircuitPython_Thermal_Printer gave a lookup string of printer.

This changes the the rfind() to look for CircuitPython_ instead, ensuring that the whole library name is captured.

Also fixed a couple latent bugs from the refactor, wrt to the -v command line flag.

@sommersoft sommersoft requested review from dhalbert, kattni and tannewt May 7, 2019 01:53
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@makermelissa makermelissa merged commit cb62109 into adafruit:master May 7, 2019
@sommersoft sommersoft deleted the fix_simpltst branch March 15, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants