Skip to content

Fix Example Checks #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix Example Checks #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e0b30
cp_lib_vals: change how repo name is determined for example file checks
sommersoft May 7, 2019
75ea69c
cp_libs: fix '-v' cmd line flag after previous changes
sommersoft May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adabot/circuitpython_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ def print_issue_overview(*insights):
startup_message.append(" - Report output will be saved to: {}".format(output_filename))

validators = []
validator_names = []
if cmd_line_args.validator:
if cmd_line_args.validator != "all":
validators = []
Expand All @@ -423,7 +424,7 @@ def print_issue_overview(*insights):

startup_message.append(" - These validators will run: {}".format(", ".join(validator_names)))

if "validate_contents" not in validators:
if "validate_contents" not in validator_names:
validator_kwarg_list["validate_contents_quiet"] = True
validators.insert(0, [val[1] for val in default_validators if "validate_contents" in val[0]][0])

Expand Down
2 changes: 1 addition & 1 deletion adabot/lib/circuitpython_library_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ def validate_contents(self, repo):
if len(examples_list) < 1:
errors.append(ERROR_MISSING_EXAMPLE_FILES)
else:
lib_name = repo["name"][repo["name"].rfind("_") + 1:].lower()
lib_name = repo["name"][repo["name"].rfind("CircuitPython_") + 14:].lower()
all_have_name = True
simpletest_exists = False
for example in examples_list:
Expand Down