Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HttpResponseLocation to Support select Attribute #461

Closed
NikolaAnovic opened this issue Aug 1, 2024 · 1 comment · Fixed by #462
Closed

Extend HttpResponseLocation to Support select Attribute #461

NikolaAnovic opened this issue Aug 1, 2024 · 1 comment · Fixed by #462

Comments

@NikolaAnovic
Copy link
Contributor

Description

I would like to propose an enhancement to the HttpResponseLocation class. Currently, this class provides a way to handle HTTP responses with location headers, primarily supporting URL redirection. However, the HTMX library also supports a select element as part of the hx-location feature, which allows for more dynamic client-side redirections.

References
• HTMX hx-location documentation
• django-htmx HttpResponseLocation source code

I am willing to implement this feature and submit a pull request for review.
NikolaAnovic pushed a commit to NikolaAnovic/django-htmx that referenced this issue Aug 1, 2024
Add select option to HttpResponseLocation class (adamchainz#461)
8af4681
NikolaAnovic pushed a commit to NikolaAnovic/django-htmx that referenced this issue Aug 1, 2024
Add select option to HttpResponseLocation class (adamchainz#461)
6c67194
NikolaAnovic pushed a commit to NikolaAnovic/django-htmx that referenced this issue Aug 1, 2024
Add select option to HttpResponseLocation class (adamchainz#461)
3df0db0
@adamchainz
Copy link
Owner

Great, this was added to htmx later per bigskysoftware/htmx#2022 . Reviewing PR now.

@adamchainz adamchainz mentioned this issue Aug 1, 2024
Merged
adamchainz added a commit that referenced this issue Aug 1, 2024
@NikolaAnovic @adamchainz
Add 'select' parameter to HttpResponseLocation (#462)
a31573f 
Fixes #461.

---------

Co-authored-by: Nikola Anović <anovic@Nikolas-MacBook-Pro.local>
Co-authored-by: Adam Johnson <me@adamj.eu>
@Nizzy94 Nizzy94 mentioned this issue Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'select' parameter to HttpResponseLocation NikolaAnovic/django-htmx
2 participants
@adamchainz @NikolaAnovic