Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'select' parameter to HttpResponseLocation #462

Conversation

NikolaAnovic
Copy link
Contributor

@NikolaAnovic NikolaAnovic commented Aug 1, 2024

Extend HttpResponseLocation to support select as an option. Fixes #461.

@NikolaAnovic NikolaAnovic force-pushed the feature/select-in-http-response-location branch from 8af4681 to 6c67194 Compare August 1, 2024 12:03
@NikolaAnovic NikolaAnovic force-pushed the feature/select-in-http-response-location branch from 6c67194 to 3df0db0 Compare August 1, 2024 12:04
@adamchainz
Copy link
Owner

Please write the issue number in the body of your PR description like Fixes #<number>, as I’ve just done for you. Then it will be closed automatically - see https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@adamchainz adamchainz changed the title Add select option to HttpResponseLocation class (#461) Add 'select' argument to HttpResponseLocation Aug 1, 2024
@adamchainz adamchainz changed the title Add 'select' argument to HttpResponseLocation Add 'select' parameter to HttpResponseLocation Aug 1, 2024
@adamchainz
Copy link
Owner

Thank you for the thorough PR. Everything was in good shape, I just needed to add a changelog note.

@adamchainz adamchainz merged commit a31573f into adamchainz:main Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend HttpResponseLocation to Support select Attribute
2 participants