Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Introduce new client_fn signature #3697

Merged
merged 20 commits into from
Jun 30, 2024
Merged

feat(framework) Introduce new client_fn signature #3697

merged 20 commits into from
Jun 30, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jun 29, 2024 •
edited
Loading

Modify client_fn signature. Support previous signature through an adaptor (see #3700 ). The old signature for client_fn is deprecated.

Base automatically changed from pass-partition-id-from-context to main June 29, 2024 18:46
@jafermarq jafermarq marked this pull request as ready for review June 29, 2024 19:20
@jafermarq jafermarq mentioned this pull request Jun 30, 2024
Merged
danieljanes
danieljanes previously approved these changes Jun 30, 2024
View reviewed changes
@danieljanes danieljanes changed the title feat(framework) Modify client_fn signature feat(framework) Introduce new client_fn signature Jun 30, 2024
@danieljanes danieljanes enabled auto-merge (squash) June 30, 2024 16:32
@danieljanes danieljanes merged commit 04fb0d7 into main Jun 30, 2024
29 checks passed
@danieljanes danieljanes deleted the change-client-fn-signature branch June 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes