Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break(framework) Remove support for client_ids in start_simulation #3699

Merged
merged 19 commits into from
Jul 7, 2024
Merged

break(framework) Remove support for client_ids in start_simulation #3699

merged 19 commits into from
Jul 7, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jun 29, 2024 •
edited
Loading

RayClientProxy objects now receive a node-id and partition-id from a mapping generated in the same way as in the Flower-Next compatible Simulation Engine (excluding the fact there's no SuperLink state).

Subsequent PRs should remove the usage of cid in simulation/ray_actor.py

@jafermarq jafermarq marked this pull request as ready for review June 29, 2024 19:20
@jafermarq @danieljanes
Apply suggestions from code review
ffe8b73 
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@jafermarq jafermarq mentioned this pull request Jun 29, 2024
Merged
@jafermarq jafermarq changed the title refactor(framework) Start phasing out cid usage in RayClientProxy break(framework) Start phasing out cid usage in RayClientProxy Jun 30, 2024
jafermarq and others added 3 commits July 1, 2024 14:22
@danieljanes danieljanes changed the title break(framework) Start phasing out cid usage in RayClientProxy break(framework) Remove support for client_ids in start_simulation Jul 7, 2024
@danieljanes danieljanes enabled auto-merge (squash) July 7, 2024 11:52
@danieljanes danieljanes merged commit d3aec92 into main Jul 7, 2024
30 checks passed
@danieljanes danieljanes deleted the refactor-rayclientproxy branch July 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes