Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Make flower-supernode run in subprocess mode by default #4485

Merged
merged 62 commits into from
Nov 15, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Nov 13, 2024

Merge after #4490.

@chongshenng chongshenng marked this pull request as ready for review November 13, 2024 08:42
@chongshenng chongshenng changed the base branch from main to break/remove-flower-server-app November 14, 2024 15:46
panh99
panh99 previously approved these changes Nov 14, 2024
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from break/remove-flower-server-app to main November 15, 2024 12:48
@danieljanes danieljanes dismissed panh99’s stale review November 15, 2024 12:48

The base branch was changed.

@danieljanes danieljanes enabled auto-merge (squash) November 15, 2024 12:57
@danieljanes danieljanes merged commit 581f3fd into main Nov 15, 2024
55 checks passed
@danieljanes danieljanes deleted the set-subprocess-default-on-supernode branch November 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants