Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FedYogi to match the paper #885

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Fix FedYogi to match the paper #885

merged 2 commits into from
Oct 28, 2021

Conversation

Jueun-Park
Copy link
Contributor

There was a nan issue in the aggregated model so I found an error in the code.

@tanertopal
Copy link
Member

@Jueun-Park thank you for this PR!

@pedropgusmao This might be something you could have a look into. Wdyt?

@pedropgusmao
Copy link
Contributor

Yep, it appears to be a significant typo. Thanks, @Jueun-Park

@pedropgusmao pedropgusmao self-requested a review October 23, 2021 07:36
@pedropgusmao pedropgusmao mentioned this pull request Oct 27, 2021
Closed
tanertopal
tanertopal approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jueun-Park @pedropgusmao Thank you both!

@tanertopal tanertopal merged commit 1b8dc4c into adap:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropgusmao pedropgusmao pedropgusmao approved these changes

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jueun-Park @tanertopal @pedropgusmao