Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapter configuration strings & restructure adapter method docs #465

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

calpt
Copy link
Member

@calpt calpt commented Dec 23, 2022

Configuration strings

This PR adds the possibility to use flexible adapter configuration strings which allow specifying custom config attributes.
Examples:

Documentation: https://github.com/calpt/adapter-transformers/blob/8df62b9de2a8ab51115b191aca35b2fb53c96539/adapter_docs/overview.md

Configuration strings can allow passing complex configurations e.g. via command line.

Documentation restructuring

The adapter method documentation is now split into three pages:

  • Overview and Configuration: introduction, table, configuration
  • Adapter Methods
  • Method Combinations

@calpt calpt marked this pull request as ready for review December 23, 2022 17:51
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calpt calpt merged commit 2e4abdb into adapter-hub:master Feb 1, 2023
@calpt calpt deleted the dev/config_strings branch February 1, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants