Refactor example scripts to leverage config strings #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on: Automatically provided by Dependent Issues (🤖). |
calpt
force-pushed
the
dev/examples-refactor
branch
from
66482c4
to
e32887d
Compare
calpt
force-pushed
the
dev/examples-refactor
branch
from
e32887d
to
f2729fb
Compare
lenglaender
reviewed
Feb 4, 2023
There was a problem hiding this comment.
When running examples/pytorch/dependency-parsing/run_udp.py I get this error:
Traceback (most recent call last):
File "/home/leon/UKP/AdapterHub/adapter-transformers/examples/pytorch/dependency-parsing/run_udp.py", line 352, in <module>
main()
File "/home/leon/UKP/AdapterHub/adapter-transformers/examples/pytorch/dependency-parsing/run_udp.py", line 173, in main
language = adapter_args.language
AttributeError: 'AdapterArguments' object has no attribute 'language'
Also regarding examples/pytorch/dependency-parsing/run_udp.py: Is there a reason why you did not replace the code under # Setup adapters blocks with the method setup_adapter_training(..) as in the other files?
Co-authored-by: Leon Engländer <77012866+lenglaender@users.noreply.github.com>
|
Thanks, updated the udp script |
lenglaender
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #465.
This PR adds the following changes:
Breaking changes: