Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spoor scripts, hardcoded course folder #3365

Closed
oliverfoster opened this issue Feb 20, 2023 · 1 comment · Fixed by #3366
Closed

Spoor scripts, hardcoded course folder #3365

oliverfoster opened this issue Feb 20, 2023 · 1 comment · Fixed by #3366
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

Subject of the issue

It should be possible to use grunt dev --coursedir=alternative to specify a different name for build/course. The spoor script current isn't aware of this request.

https://github.com/adaptlearning/adapt-contrib-spoor/blob/3955b26fd4a1810cac98adfdc9c804440f718f40/scripts/postcopy.js#L3-L5

The coursedir variable isn't passed into scripts, so this is also not currently possible.
@oliverfoster oliverfoster self-assigned this Feb 20, 2023
@oliverfoster oliverfoster moved this from New to Assigned in adapt_framework: The TODO Board Feb 20, 2023
oliverfoster added a commit that referenced this issue Feb 20, 2023
@oliverfoster
Fix: Pass cli variables into scripts (fixes #3365)
84a08e3
@oliverfoster oliverfoster mentioned this issue Feb 20, 2023
Merged
@oliverfoster oliverfoster moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Feb 20, 2023
oliverfoster added a commit that referenced this issue Mar 9, 2023
@oliverfoster
Fix: Pass cli variables into scripts (fixes #3365) (#3366)
8484afa
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 9, 2023
github-actions bot pushed a commit that referenced this issue Mar 9, 2023
@semantic-release-bot
Chore(release): 5.28.1 [skip ci]
3a608aa 
## [5.28.1](v5.28.0...v5.28.1) (2023-03-09)

### Fix

* Pass cli variables into scripts (fixes #3365) (#3366) ([8484afa](8484afa)), closes [#3365](#3365) [#3366](#3366)
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

🎉 This issue has been resolved in version 5.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Pass cli variables into scripts (fixes #3365) adaptlearning/adapt_framework
1 participant
@oliverfoster