Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Pass cli variables into scripts (fixes #3365) #3366

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Fix: Pass cli variables into scripts (fixes #3365) #3366

merged 3 commits into from
Mar 9, 2023

Conversation

oliverfoster
Copy link
Member

fixes #3365

Fix

  • Add coursedir (and all other compliation variables) in script options arguments

@oliverfoster oliverfoster self-assigned this Feb 20, 2023
@oliverfoster oliverfoster mentioned this pull request Feb 20, 2023
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

danielghost
danielghost reviewed Mar 8, 2023
View reviewed changes
grunt/tasks/scripts.js Outdated Show resolved Hide resolved
danielghost
danielghost requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@danielghost danielghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestion: https://github.com/adaptlearning/adapt_framework/pull/3366/files#r1129390620

@oliverfoster oliverfoster merged commit 8484afa into master Mar 9, 2023
@oliverfoster oliverfoster deleted the issue/3365 branch March 9, 2023 12:31
github-actions bot pushed a commit that referenced this pull request Mar 9, 2023
@semantic-release-bot
Chore(release): 5.28.1 [skip ci]
3a608aa 
## [5.28.1](v5.28.0...v5.28.1) (2023-03-09)

### Fix

* Pass cli variables into scripts (fixes #3365) (#3366) ([8484afa](8484afa)), closes [#3365](#3365) [#3366](#3366)
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

🎉 This PR is included in version 5.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@danielghost danielghost danielghost approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spoor scripts, hardcoded course folder
4 participants
@oliverfoster @swashbuck @danielghost @cahirodoherty-learningpool