Refresh globals in course JSON #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| "ariaRegion": "Below is a component which allows you to select hot spots over an image. Select a hot spot to trigger a popup that includes an image with display text. Select the close button to close the popup." | ||
| "_hotgraphic": { | ||
| "ariaRegion": "Below is a component which allows you to select hot spots over an image. Select a hot spot to trigger a popup that includes an image with display text. Select the close button to close the popup.", | ||
| "ariaPoupupLabel": "Hotgraphic popup" |
There was a problem hiding this comment.
Possible typo... suspect 'Poupup' is not what you meant ;-)
While we're on this one... is a user of e-learning going to know what 'hot spots' are or what a 'hot graphic' is? I certainly remember finding this terminology extremely odd when I first started working in the industry.
There was a problem hiding this comment.
Keen spot! I didn't actually type anything – everything in this PR was pulled automatically from schemas. This will then need fixing: https://github.com/adaptlearning/adapt-contrib-hotgraphic/blob/master/properties.schema#L15.
There was a problem hiding this comment.
good point! will log a ticket
|
+1 |
2 similar comments
|
+1 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the fix to the schema-defaults Grunt task in #1101, this PR resolves the apparent inconsistencies between the source and build globals.