Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh globals in course JSON #1136

Merged
merged 2 commits into from
Jul 15, 2016
Merged

Refresh globals in course JSON #1136

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56d2a31
Refresh globals in course JSON
tomgreenfield Jul 12, 2016
12e784d
Fix @moloko's findings
tomgreenfield Jul 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/course/en/course.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,15 @@
"_accordion": {
"ariaRegion": "This component is an accordion comprised of collapsible content panels containing display text. Select the item titles to toggle the visibility of these content panels."
},
"_blank": {
"ariaRegion": ""
},
"_gmcq": {
"ariaRegion": "This component is a graphical multiple choice question. Once you have selected an option select the submit button below."
},
"_graphic": {
"ariaRegion": ""
},
"_hotGraphic": {
"ariaRegion": "Below is a component which allows you to select hot spots over an image. Select a hot spot to trigger a popup that includes an image with display text. Select the close button to close the popup."
"_hotgraphic": {
"ariaRegion": "Below is a component which allows you to select hot spots over an image. Select a hot spot to trigger a popup that includes an image with display text. Select the close button to close the popup.",
"ariaPoupupLabel": "Hotgraphic popup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible typo... suspect 'Poupup' is not what you meant ;-)

While we're on this one... is a user of e-learning going to know what 'hot spots' are or what a 'hot graphic' is? I certainly remember finding this terminology extremely odd when I first started working in the industry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keen spot! I didn't actually type anything – everything in this PR was pulled automatically from schemas. This will then need fixing: https://github.com/adaptlearning/adapt-contrib-hotgraphic/blob/master/properties.schema#L15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! will log a ticket

},
"_matching": {
"ariaRegion": "This question component requires you to select the matching answer from a drop down list below. When you have selected your answers select the submit button."
Expand All @@ -54,7 +52,8 @@
"ariaRegion": "This component is a multiple choice question. Once you have selected an option select the submit button below."
},
"_media": {
"ariaRegion": "This is a media component which plays a video. Select the play / pause button to watch or listen. Alternatively you can select the link below for the transcript."
"ariaRegion": "This is a media component which plays a video. Select the play / pause button to watch or listen. Alternatively you can select the link below for the transcript.",
"transcriptButton": "Alternatively you can select the link below for the transcript."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the duplication of "Alternatively you can select the link below for the transcript" correct?

(And strictly speaking, it's a button not a link)

Copy link
Contributor Author

@tomgreenfield tomgreenfield Jul 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, it looks like it got separated out here, but the duplication crept in here. I'll remove it from the aria region again to match the schema unless anyone has any objections.

},
"_narrative": {
"ariaRegion": "This component displays an image gallery with accompanying text. Use the next and back navigation controls to work through the narrative."
Expand All @@ -65,22 +64,23 @@
"_text": {
"ariaRegion": ""
},
"_textInput": {
"_textinput": {
"ariaRegion": "This question component requires you to input your answer in the textbox provided. When you have answered the question select the submit button below."
}
},
"_extensions": {
"_pageLevelProgress": {
"pageLevelProgress": "Page sections",
"pageLevelProgressEnd": "You have reached the end of the list of page sections.",
"pageLevelProgressIndicatorBar": "Progress bar. Select here to view your current progress, and select an item to navigate to it. You have completed ",
"pageLevelProgressMenuBar": "You have completed ",
"pageLevelProgressEnd": "You have reached the end of the list of page sections.",
"optionalContent": "Optional Content"
}
},
"_menu": {
"_boxmenu": {
"ariaRegion": "Menu",
"durationLabel": "Duration:",
"menuItem": "Menu item.",
"menuEnd": "You have reached the end of the menu."
}
Expand Down