Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use signal if verbose #18

Merged
merged 4 commits into from
Apr 21, 2023
Merged

fix: only use signal if verbose #18

merged 4 commits into from
Apr 21, 2023

Conversation

adbar
Copy link
Owner

@adbar adbar commented Apr 19, 2023

No description provided.

@adbar adbar marked this pull request as draft April 19, 2023 11:24
@adbar adbar linked an issue Apr 19, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #18 (fae2c44) into master (968fd5d) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          670       670           
=========================================
  Hits           670       670           
Impacted Files Coverage Δ
courlan/urlstore.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adbar adbar marked this pull request as ready for review April 21, 2023 11:10
@adbar adbar merged commit 406d485 into master Apr 21, 2023
@adbar adbar deleted the fix_signal branch April 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of signal optional
2 participants