fix: only use signal if verbose (Sourcery refactored) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-117
to
+122
| candidate = "https" + domain[4:] | ||
| candidate = f"https{domain[4:]}" | ||
| # switch | ||
| if candidate in self.urldict: | ||
| domain = candidate | ||
| elif domain.startswith("https://"): | ||
| candidate = "http" + domain[5:] | ||
| candidate = f"http{domain[5:]}" |
There was a problem hiding this comment.
Function UrlStore._store_urls refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
| if website in self.urldict: | ||
| return self.urldict[website].rules | ||
| return None | ||
| return self.urldict[website].rules if website in self.urldict else None |
There was a problem hiding this comment.
Function UrlStore.get_rules refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-201
to
+202
| example_domain + "/this", | ||
| example_domain + "/999", | ||
| f"{example_domain}/this", | ||
| f"{example_domain}/999", |
There was a problem hiding this comment.
Function test_urlstore refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #18 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
fix_signalbranch, then run:Help us improve this pull request!