Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data written by dictionary_pickler.py #156

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Nov 5, 2024

The changes to the return types of DictionaryFactory.get_dictionary() in 63933fc broke the generation of dictionaries using training/dictionary_pickler.py. This commit fixes that again, by undoing the changes to training/dictionary_pickler.py made by 63933fc.

Verified

This commit was signed with the committer’s verified signature.
Dunedan Daniel Roschka
The changes to the return types of `DictionaryFactory.get_dictionary()`
in 63933fc broke the generation of dictionaries using
`training/dictionary_pickler.py`. This commit fixes that again, by
undoing the changes to `training/dictionary_pickler.py` made by 63933fc.

Verified

This commit was signed with the committer’s verified signature.
Dunedan Daniel Roschka
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (10cc7fb) to head (7f1b2df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          35       35           
  Lines         620      620           
=======================================
  Hits          603      603           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar linked an issue Nov 5, 2024 that may be closed by this pull request
@adbar
Copy link
Owner

adbar commented Nov 5, 2024

Neat, thanks!

@adbar adbar merged commit db5f5d8 into adbar:main Nov 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken dictionary building
2 participants